Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

Fixing Logical Errors and Removing "TODO REMOVE" code #201

Open
matawoo wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fixing Logical Errors and Removing "TODO REMOVE" code #201

matawoo wants to merge 5 commits into from

Conversation

@matawoo
Copy link

@matawoo matawoo commented Jul 20, 2021

  • Fixing a Logical error in "read_video" that incorrectly breaks the loop if "i" is less than the limit, leaving the frame array empty.
  • Removing code that removes the first "input_video_skip", effectively leaving the visualisations unsynchronised as the points would be ahead of the video by "input_video_skip" frames.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matawoo @facebook-github-bot