Strategy methods act on copies of models if needed #645
Conversation
facebook-github-bot
added
the
CLA Signed
JasonKChow
force-pushed
the
pr645
branch
6 times, most recently
from
06e6fe6 to
61f22b0
Compare
Summary: Rewrite the server to use asyncio and be multithreaded. Allows handling multiple clients. Test Plan: Tests updated. Later test also tests multiple db writes simultaneously.
Summary: Use scoped sessions that is shared between threads to allow async db operations. Test Plan: Tests should pass
Summary: Logging levels were used inconsistently and would cause problems with multithreaded servers. We remove this ability. Test Plan: Tests updated.
Summary: All message handlers will emit a info logging message to support better live tracking of server functions. Test Plan: Tests should pass
Summary: To support multi client server, strategy methods will not act on copies of models to avoid changing tensor gradients between two threads. Test Plan: New test
|
Hi @JasonKChow! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Summary: To support multi client server, strategy methods will not act on copies of models to avoid changing tensor gradients between two threads.
Test Plan: New test
Stack created with Sapling. Best reviewed with ReviewStack.