Patched to build on cuda12.4 on windows system #4456
Conversation
|
Hi @Sanjib-ac! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| find_package(OpenMP REQUIRED) | ||
| #find_package(OpenMP REQUIRED) | ||
| find_package(OpenMP REQUIRED COMPONENTS CXX) | ||
| find_package(OpenMP OPTIONAL_COMPONENTS CUDA) |
There was a problem hiding this comment.
CUDA may not be included for non GPU builds, so similar to above, if you need OpenMP for Windows CUDA builds, let's add a condition
| LANGUAGES ${FAISS_LANGUAGES}) | ||
|
|
||
| # Force OpenMP_CUDA so MSVC+CUDA builds don’t abort when FAISS_ENABLE_GPU=ON | ||
| if(FAISS_ENABLE_GPU) |
There was a problem hiding this comment.
I am just starting the CI workflows now, but I think we would want these blocks only if compiling on Windows.
|
The .cu and .cuh changes seem OK, but there are some format errors. Can you see the logs in https://github.com/facebookresearch/faiss/actions/runs/16512198656/job/46740224166?pr=4456 ? |
3 participants
Patched files to support CUDA 12.4 on Windows. Also bypassed the OpenMP_CUDA requirement; a warning will be shown.