SIMDConfig object + SIMD detections #4552
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937710 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
6b9c311 to
39d1361
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937710 |
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
39d1361 to
d53fa20
Compare
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937710 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebookresearch#4552 Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
d53fa20 to
083b075
Compare
| #endif // __x86_64__ | ||
|
|
||
| std::pair<bool, std::vector<int>> try_execute(std::vector<int> (*func)()) { | ||
| signal(SIGILL, sigill_handler); |
Contributor
There was a problem hiding this comment.
this is linux-specific
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
083b075 to
038db06
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937710 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
038db06 to
1e36e43
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937710 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
1e36e43 to
ae093b1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937710 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
ae093b1 to
5c8261d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937710 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
5c8261d to
a0a3657
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937710 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
a0a3657 to
c440da1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937710 |
| supported_simd_levels().clear(); | ||
| supported_simd_levels().insert(matched_level.value()); | ||
| } else { | ||
| fprintf(stderr, |
Contributor
There was a problem hiding this comment.
I think that a better reaction would be to issue a warning rather than terminate a program
| } | ||
|
|
||
| std::string SIMDConfig::get_level_name() { | ||
| return to_string(level).value_or(""); |
Contributor
There was a problem hiding this comment.
return to_string(level).value_or("unknown"); ?
| SIMDLevel level = SIMDLevel::NONE; | ||
|
|
||
| #if defined(__x86_64__) && \ | ||
| (defined(COMPILE_SIMD_AVX2) || defined(COMPILE_SIMD_AVX512)) |
Contributor
There was a problem hiding this comment.
The logic must be separated. A CPU-capability detection facility must detect all CPU features. And then following code must decide SIMDLevel to use, based on possible #pragma definitions.
| return "AVX2"; | ||
| case SIMDLevel::AVX512: | ||
| return "AVX512"; | ||
| case SIMDLevel::ARM_NEON: |
Contributor
There was a problem hiding this comment.
AVX512 for Sapphire Rapids (AVX512_SPR or similar) ?
| return "AVX512"; | ||
| case SIMDLevel::ARM_NEON: | ||
| return "ARM_NEON"; | ||
| default: |
Contributor
There was a problem hiding this comment.
also, I've seen the code for ARM SVE somewhere in Faiss, maybe, in incoming PRs
| } | ||
|
|
||
| std::optional<SIMDLevel> to_simd_level(const std::string& level_str) { | ||
| if (level_str == "NONE") { |
Contributor
There was a problem hiding this comment.
std::toupper() must be used
| // arm & aarch64 | ||
| ARM_NEON, | ||
|
|
||
| COUNT |
Contributor
There was a problem hiding this comment.
any other platforms?
| // arm & aarch64 | ||
| ARM_NEON, | ||
|
|
||
| COUNT |
Contributor
There was a problem hiding this comment.
What is COUNT exactly? :)
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
c440da1 to
ec40e4d
Compare
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 27, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 27, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937710 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 27, 2025
Summary: Pull Request resolved: facebookresearch#4552 Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
ec40e4d to
4e08a32
Compare
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 28, 2025
Summary: Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
4e08a32 to
09ccb86
Compare
Summary: Pull Request resolved: facebookresearch#4552 Implementation of: - `SIMDLevel` that can be used as a template parameter to differentiate implementations - `SIMDConfig` object that defines what is the enabled SIMDLevel in the TARGETS all SIMD code is disabled by default. Reviewed By: mnorris11 Differential Revision: D72937710
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937710 |
subhadeepkaran
force-pushed
the
export-D72937710
branch
from
09ccb86 to
8134c8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implementation of:
SIMDLevelthat can be used as a template parameter to differentiate implementationsSIMDConfigobject that defines what is the enabled SIMDLevelin the TARGETS all SIMD code is disabled by default.
Reviewed By: mnorris11
Differential Revision: D72937710