dynamic dispatch distances_simd #4553
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937708 |
subhadeepkaran
force-pushed
the
export-D72937708
branch
from
887faee to
fe0f6a3
Compare
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: `fvec_madd` is the first function to test dispatching to AVX and AVX512 distances_simd.cpp is split into specialized files distances_avx2.cpp distances_avx512.cpp that are compiled with appropriate flags. Reviewed By: mnorris11 Differential Revision: D72937708
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937708 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebookresearch#4553 `fvec_madd` is the first function to test dispatching to AVX and AVX512 distances_simd.cpp is split into specialized files distances_avx2.cpp distances_avx512.cpp that are compiled with appropriate flags. Reviewed By: mnorris11 Differential Revision: D72937708
subhadeepkaran
force-pushed
the
export-D72937708
branch
from
fe0f6a3 to
7fb1823
Compare
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: `fvec_madd` is the first function to test dispatching to AVX and AVX512 distances_simd.cpp is split into specialized files distances_avx2.cpp distances_avx512.cpp that are compiled with appropriate flags. Reviewed By: mnorris11 Differential Revision: D72937708
subhadeepkaran
force-pushed
the
export-D72937708
branch
from
7fb1823 to
b236273
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937708 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: `fvec_madd` is the first function to test dispatching to AVX and AVX512 distances_simd.cpp is split into specialized files distances_avx2.cpp distances_avx512.cpp that are compiled with appropriate flags. Reviewed By: mnorris11 Differential Revision: D72937708
subhadeepkaran
force-pushed
the
export-D72937708
branch
from
b236273 to
b916ec0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937708 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: `fvec_madd` is the first function to test dispatching to AVX and AVX512 distances_simd.cpp is split into specialized files distances_avx2.cpp distances_avx512.cpp that are compiled with appropriate flags. Reviewed By: mnorris11 Differential Revision: D72937708
subhadeepkaran
force-pushed
the
export-D72937708
branch
from
b916ec0 to
00da9fe
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937708 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: `fvec_madd` is the first function to test dispatching to AVX and AVX512 distances_simd.cpp is split into specialized files distances_avx2.cpp distances_avx512.cpp that are compiled with appropriate flags. Reviewed By: mnorris11 Differential Revision: D72937708
subhadeepkaran
force-pushed
the
export-D72937708
branch
from
00da9fe to
6910497
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937708 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: `fvec_madd` is the first function to test dispatching to AVX and AVX512 distances_simd.cpp is split into specialized files distances_avx2.cpp distances_avx512.cpp that are compiled with appropriate flags. Reviewed By: mnorris11 Differential Revision: D72937708
subhadeepkaran
force-pushed
the
export-D72937708
branch
from
6910497 to
8814705
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937708 |
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: `fvec_madd` is the first function to test dispatching to AVX and AVX512 distances_simd.cpp is split into specialized files distances_avx2.cpp distances_avx512.cpp that are compiled with appropriate flags. Reviewed By: mnorris11 Differential Revision: D72937708
subhadeepkaran
force-pushed
the
export-D72937708
branch
from
8814705 to
1c22fc5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937708 |
|
|
||
| #include <faiss/utils/distances.h> | ||
|
|
||
| #define AUTOVEC_LEVEL SIMDLevel::ARM_NEON |
Contributor
There was a problem hiding this comment.
the name of the file should be changed to distances_arm_neon.cpp
…DQ, Vl, DL) detection
Summary:
* Added support to detect SIMD instruction set for both `AVX2` and `AVX512F, AVX512VL` related levels
* Added hardware specific unit tests (eg: checks when unit tests are ran on x86 arch then relevant SIMD levels are returned, also respective instructions are executed)
* Reason for explicitly running computation and not relying on `__builtin_cpu_supports("avx512f")` [link](https://stackoverflow.com/questions/48677575/does-gccs-builtin-cpu-supports-check-for-os-support)
* Also, fixes the bug in existing `AVX2` detection
* Incorrect CPUID Bit Check: Function uses `ebx & (1 << 16)` to check for `AVX2` support. This is incorrect because bit 16 in `ebx` is actually used for `AVX-512F`, not `AVX2`.
* Correct Bit for AVX2: Correct bit for detecting AVX2 is bit 5 in `ebx` when `eax = 7` and `ecx = 0`. This is based on Intel's documentation for the CPUID instruction.
* Another bug observed in constructor for SIMDConfig (if env variable is set, the codepath still follows detection via code)
* Improving SIMDConfig to take parameters to its constructor to support and enable injection mechanism for better testing* Adding more unit tests for other Hardware
* Added variable with SIMDConfig to track all possible supported SIMD Levels
Differential Revision: D72937710
Reviewed By: mdouze
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 27, 2025
Summary: `fvec_madd` is the first function to test dispatching to AVX and AVX512 distances_simd.cpp is split into specialized files distances_avx2.cpp distances_avx512.cpp that are compiled with appropriate flags. Reviewed By: mnorris11 Differential Revision: D72937708
subhadeepkaran
force-pushed
the
export-D72937708
branch
from
1c22fc5 to
8a37e1b
Compare
Summary: Pull Request resolved: facebookresearch#4553 `fvec_madd` is the first function to test dispatching to AVX and AVX512 distances_simd.cpp is split into specialized files distances_avx2.cpp distances_avx512.cpp that are compiled with appropriate flags. Reviewed By: mnorris11 Differential Revision: D72937708
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937708 |
subhadeepkaran
force-pushed
the
export-D72937708
branch
from
8a37e1b to
f2273a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fvec_maddis the first function to test dispatching to AVX and AVX512distances_simd.cpp is split into specialized files distances_avx2.cpp distances_avx512.cpp that are compiled with appropriate flags.
Reviewed By: mnorris11
Differential Revision: D72937708