Speed up polysemous training with AVX-512. #4578
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds AVX-512 implementations of the
compute_costandcost_updatefunctions used in polysemous training. Benchmarks of the training phase withbenchs/bench_polysemous_sift1m.pyshow ~1.5x speedup over the existing scalar implementation, which relied only on partial auto-vectorization.Once the SIMD support overhaul is complete, I hope this can be considered for integration.
cc: @mdouze @subhadeepkaran