Parallelize compute_residuals in IndexIVFPQ #4654
Open
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OpenMP parallelization to compute_residuals function. This addresses the TODO comment about parallelization. Changes: - Add #pragma omp parallel for to residual computation loop - Use if(n > 1000) to avoid overhead for small batches - Each iteration is independent and thread-safe
Contributor
|
@limqiying has imported this pull request. If you are a Meta employee, you can view this in D86234690. |
|
Hi @Ray0907 did you try benchmarking it? Do you observe speedup? If yes, can you paste the script you used here? |
MSVC requires signed integral type for OpenMP loop variables. Changed from size_t to idx_t in compute_residuals().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OpenMP parallelization to compute_residuals function.
This addresses the TODO comment about parallelization.
Changes: