Fix deprecated dynamic exception in fboss/agent/hw/bcm/BcmError.h +5 #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: LLVM has detected a violation of `-Wdeprecated-dynamic-exception-spec`. Dynamic exceptions were removed in C++17. This diff fixes the deprecated instance(s). See [Dynamic exception specification](https://en.cppreference.com/w/cpp/language/except_spec) and [noexcept specifier](https://en.cppreference.com/w/cpp/language/noexcept_spec). Differential Revision: D57636124
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57636124 |
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
May 23, 2024
Summary: X-link: facebookresearch/fbpcf#539 LLVM has detected a violation of `-Wdeprecated-dynamic-exception-spec`. Dynamic exceptions were removed in C++17. This diff fixes the deprecated instance(s). See [Dynamic exception specification](https://en.cppreference.com/w/cpp/language/except_spec) and [noexcept specifier](https://en.cppreference.com/w/cpp/language/noexcept_spec). Reviewed By: palmje Differential Revision: D57636124 fbshipit-source-id: 90ff1837d7d7aa919ea19d380b638a04b7d19adf
|
This pull request has been merged in e350310. |
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
May 23, 2024
Summary: X-link: facebookresearch/fbpcf#539 LLVM has detected a violation of `-Wdeprecated-dynamic-exception-spec`. Dynamic exceptions were removed in C++17. This diff fixes the deprecated instance(s). See [Dynamic exception specification](https://en.cppreference.com/w/cpp/language/except_spec) and [noexcept specifier](https://en.cppreference.com/w/cpp/language/noexcept_spec). Reviewed By: palmje Differential Revision: D57636124 fbshipit-source-id: 90ff1837d7d7aa919ea19d380b638a04b7d19adf
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
May 23, 2024
Summary: X-link: facebookresearch/fbpcf#539 LLVM has detected a violation of `-Wdeprecated-dynamic-exception-spec`. Dynamic exceptions were removed in C++17. This diff fixes the deprecated instance(s). See [Dynamic exception specification](https://en.cppreference.com/w/cpp/language/except_spec) and [noexcept specifier](https://en.cppreference.com/w/cpp/language/noexcept_spec). Reviewed By: palmje Differential Revision: D57636124 fbshipit-source-id: 90ff1837d7d7aa919ea19d380b638a04b7d19adf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
LLVM has detected a violation of
-Wdeprecated-dynamic-exception-spec. Dynamic exceptions were removed in C++17. This diff fixes the deprecated instance(s).See Dynamic exception specification and noexcept specifier.
Differential Revision: D57636124