Implementing signing into onedocker-cli #369
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 14, 2022 11:53
Summary: Pull Request resolved: facebookresearch#359 # Context Want to move s3 i/o out of attestation service. # This commit Creates tooling that would enable move to happen, and changes checksum path to follow styling of repository path for simplicity Differential Revision: D37524841 fbshipit-source-id: 61c1b77dbb0b3528ddb28afa483917687ca2b9a2
Summary: Added functionalilty to upload in last commit, this extends this to also include downloading of checksum file Differential Revision: D37525237 fbshipit-source-id: 91ad63ffa84f13f3327feb8fb2009afb2940a935
Summary: Pull Request resolved: facebookresearch#360 # Context We added functionality to upload checksums to ODPR, but dont use it atm. # This commit Removes the uploading from AttestationService and puts it into ODPR. Differential Revision: D37526228 fbshipit-source-id: 02e614cdf62c0306dd02a0ddc1d003f19f9b0439
Summary: # Context Want to move all s3 i/o out of AttestationService # This Commit Moves download from AttestationService to ODPR Differential Revision: D37526823 fbshipit-source-id: edbab0fe34a897b105f5e8b931f790894367c573
Differential Revision: D37566562 fbshipit-source-id: 16ad1ec81368249e4b1f86e3e04310b288a950c2
Summary: Just adding some logs to help clean up output Differential Revision: D37527124 fbshipit-source-id: 34be54dcad0a6238b02b897228dbc18f99588283
Summary: Pull Request resolved: facebookresearch#344 # Context What good is integration if no easy way to interact when running program from CLI # This commit Adds default and env variable lookup allowing run from CLI Differential Revision: D37229577 fbshipit-source-id: 9c63375ca8a03469baa509a9301dfdf426e03480
Summary: Pull Request resolved: facebookresearch#331 # Context Now that all the tooling should be done, we want some more comprehensive tests to check everything works as it should # This commit Adds many tests both through s3 and locally to verify that code is working as it should Differential Revision: D36839896 fbshipit-source-id: 4ca362a7e98574ffda0887c0345e04abcd17cc83
Differential Revision: D37400919 fbshipit-source-id: 8bd7a0c52529be595bddf061c4295b41818cb6fe
Differential Revision: https://www.internalfb.com/diff/D37403863?entry_point=27 fbshipit-source-id: b55966a846d060a68938751567123d0bb8571365
Differential Revision: D37838138 fbshipit-source-id: 119ae819940590e92605fdbacb96d4fd5c6f8892
Differential Revision: D37667144 fbshipit-source-id: 6bd8f9bff32853be2001d9bc5a4edcdee4fcf6b5
Differential Revision: D37838812 fbshipit-source-id: f70077ab5931da023e22656c2de04f00f30c2753
Differential Revision: D37838898 fbshipit-source-id: 45b6d39663047527d1792b2ac7b62b7dd757db44
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37838898 |
|
Hi @IamStegoMan! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D37838898