Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--Provide mesh surface area, volume and topology tools #2437

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

--Provide mesh surface area, volume and topology tools #2437

wants to merge 5 commits into from

Conversation

jturner65
Copy link
Collaborator

@jturner65 jturner65 commented Jul 29, 2024 •
edited
Loading

Motivation and Context

This PR will provide mesh surface area and volume calculations for watertight manifold meshes. It also tests the mesh topology to note whether or not ever edge is adjacent to exactly 2 faces (closed/watertight and manifold).
TODO : Currently needs bindings to access values and config-driven boolean to potentially gate calculation.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 29, 2024
@jturner65 jturner65 requested a review from aclegg3 July 30, 2024 16:51
@jturner65 jturner65 changed the title --Provide mesh surface area and volume calc tools --Provide mesh surface area, volume and topology tools Jul 30, 2024
@jturner65 jturner65 force-pushed the MeshGeoTools branch 2 times, most recently from e86bf5e to f97db4f Compare August 13, 2024 13:56
@jturner65 jturner65 force-pushed the MeshGeoTools branch 2 times, most recently from e201f26 to c468e27 Compare August 25, 2024 15:48
@jturner65 jturner65 force-pushed the MeshGeoTools branch 2 times, most recently from 2cc9882 to 2fcd517 Compare September 5, 2024 12:56
@jturner65 jturner65 changed the base branch from main to dev September 13, 2024 13:02
@jturner65 jturner65 force-pushed the MeshGeoTools branch 2 times, most recently from 8f3140a to 52207d7 Compare September 18, 2024 17:14
Base automatically changed from dev to main November 4, 2024 16:35
@jturner65 jturner65 force-pushed the MeshGeoTools branch 2 times, most recently from d37da09 to 9def5af Compare November 11, 2024 16:03
@jturner65 jturner65 force-pushed the MeshGeoTools branch 3 times, most recently from 7f333e9 to 8a4aa60 Compare November 18, 2024 19:02
@jturner65 jturner65 force-pushed the MeshGeoTools branch 2 times, most recently from 08caa1b to e16efc3 Compare December 11, 2024 14:35
@jturner65 jturner65 force-pushed the MeshGeoTools branch 2 times, most recently from 3261738 to ca786bb Compare January 23, 2025 14:15
@jturner65 jturner65 force-pushed the MeshGeoTools branch 2 times, most recently from 8532798 to 68f8747 Compare February 4, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 Awaiting requested review from aclegg3

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jturner65 @facebook-github-bot