Deal with more Gym cases #1327
Open
Deal with more Gym cases #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jrapin
reviewed
Dec 21, 2021
nevergrad/functions/gym/multigym.py
Outdated
Comment on lines
818
to
822
| if type(a) == tuple: | ||
| try: | ||
| a = tuple(int(_a + 0.5) for _a in a) | ||
| except: # oh my FSM! A tuple of nd-array probably. | ||
| a = tuple(np.asarray(_a+.5, dtype=int) for _a in a) |
There was a problem hiding this comment.
does it have to be tuples ? np.round(a) would be much simpler
There was a problem hiding this comment.
It depends on the gym problem, not on nevergrad.
The point is to deal with (at least some) nested structures which are not ndarray.
There was a problem hiding this comment.
usually I would expect it's simpler to convert everything to array, and then update the type if need be
There was a problem hiding this comment.
There are complicated types in Gym actually. You can have a dict of tuple of ndarray or stuff like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
Checklist