Skip to content

Denisprclean #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Milloupe wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Denisprclean #1678

Milloupe wants to merge 45 commits into from

Conversation

@Milloupe
Copy link
Contributor

@Milloupe Milloupe commented Feb 27, 2025

increased resolution of mode converter
also, better readability

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 27, 2025
teytaud and others added 8 commits February 27, 2025 16:11
@teytaud
clean
8efa1d7
@teytaud
fix_unused
fbbea8a
@teytaud
black
ba1a51c
@teytaud
po
7bd7439
@teytaud @Milloupe
cleaner denis pr (facebookresearch#1675)
ea5cfbd 
* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* Denisprclean (facebookresearch#1677)

* improved converter, added bender

* improved converter, added bender

* clean

* fix_unused

* black

---------

Co-authored-by: Denis Langevin <[email protected]>
@teytaud @Milloupe
the pixel/voxel PR (facebookresearch#1679)
d4871f8 
* pixel

* fix

* cleaner denis pr (facebookresearch#1675)

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* Denisprclean (facebookresearch#1677)

* improved converter, added bender

* improved converter, added bender

* clean

* fix_unused

* black

---------

Co-authored-by: Denis Langevin <[email protected]>

* pix

* pixel

* fix

* fixpixel

* fix

* pix

* pix

---------

Co-authored-by: Denis Langevin <[email protected]>
@Milloupe
increased resolution
61012f9
@Milloupe
mend
c18a2cb
@Milloupe Milloupe changed the base branch from denisprclean to main March 28, 2025 14:45
@teytaud
Copy link
Contributor

teytaud commented Mar 31, 2025

@Milloupe Maybe you can update the base branch ? see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/keeping-your-pull-request-in-sync-with-the-base-branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Milloupe @teytaud @facebook-github-bot