Fix sorting of filenames with alphanumeric prefixes.#248
Open
branyang02 wants to merge 1 commit intofacebookresearch:mainfrom
Open
Fix sorting of filenames with alphanumeric prefixes.#248branyang02 wants to merge 1 commit intofacebookresearch:mainfrom
branyang02 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
ShuoShenDe
approved these changes
Aug 23, 2024
ShuoShenDe
left a comment
There was a problem hiding this comment.
The extract number function works when the name is with number, but fails when there are multiple numeric parts in the name
|
My solution here is to allow passing a list into it: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance filename sorting by extracting numeric parts
_extract_numericto extract numeric values from filenames containing alphanumeric characters._extract_numeric, improving handling of filenames with both numeric prefixes and postfixes (e.g., 'DSCF5858', 'IMG1234').