Skip to content

Make the CHOLMOD dependency optional #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luisenp merged 3 commits into from
Jan 16, 2025
Merged

Make the CHOLMOD dependency optional #673

luisenp merged 3 commits into from
Jan 16, 2025

Conversation

@luisenp
Copy link
Contributor

@luisenp luisenp commented Jan 16, 2025

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025
@luisenp luisenp requested a review from fantaosha January 16, 2025 17:44
fantaosha
fantaosha approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@luisenp luisenp merged commit c8583de into main Jan 16, 2025
10 checks passed
@luisenp luisenp deleted the lep.make_cholmod_dep_optional branch January 16, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fantaosha fantaosha fantaosha approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luisenp @fantaosha @facebook-github-bot