Skip to content

some binary size tests? #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

some binary size tests? #678

wants to merge 2 commits into from

Conversation

ThouCheese
Copy link
Member

No description provided.

@ThouCheese ThouCheese force-pushed the feat/code-size branch 3 times, most recently from 656d6e3 to 4358b11 Compare May 25, 2025 08:43
owner: context.repo.owner,
repo: context.repo.repo,
body: comment
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably write all this as a Rust tool itself (could be in a separate repo) or as a TypeScript codebase at least — this feels way too fragile, but 🤷 could be a start.

Copy link
Member

@lmmx lmmx May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve seen examples of Rust WASM bindings to the GitHub actions toolkit, alas doesn’t seem to have caught on 😢 I came across this which seems abandoned 6 years ago https://github.com/sethp/actions-toolkit-sys and this from someone at GitHub who likewise seems to have abandoned it https://github.com/peter-evans/rust-wasm-action/tree/master

This ‘octocrab’ crate on the other hand seems maintained and got WASM support last year 👀 (dev sponsored by catppuccin) https://github.com/XAMPPRocky/octocrab

Example use in Apache nuttx (PR review bot) https://lupyuen.org/articles/llm.html#call-the-github-api

@ThouCheese ThouCheese force-pushed the feat/code-size branch 2 times, most recently from d4cf406 to 2cca0c7 Compare May 25, 2025 18:51
@fasterthanlime
Copy link
Contributor

Are we okay closing this now that cargo-bloat & cargo-llvm-lines are ran in CI and reported as a comment?

@ThouCheese ThouCheese closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants