Skip to content

Rename SmartPointer to Pointer #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

Rename SmartPointer to Pointer #838

merged 1 commit into from
Jul 3, 2025

Conversation

fasterthanlime
Copy link
Contributor

Copy link

github-actions bot commented Jul 3, 2025

📦 limpid report

Number of crates: 51 (➖ no change)
8350 symbols (➖ no change), totaling 885.5 KB (➖ no change)

Symbol Baseline Size Current Size Change
facet_core::types::def::pointer::PointerDef::pointee
found in facet_core
14 B 🆕 NEW
facet_core::types::def::smartptr::SmartPointerDef::pointee
found in facet_core
14 B 🗑️ REMOVED
facet_core::types::def::list::ListDef::t
found in facet_core
3 B 🗑️ REMOVED
facet_core::types::def::set::SetDef::t
found in facet_core
3 B 🆕 NEW

All significant changes are listed above.

Number of LLVM lines: 351,318 (➖ no change)

Function Baseline Lines Current Lines Change
<facet_core::types::def::pointer::_::InternalBitFlags as core::fmt::Display>::fmt
found in core
148 🆕 NEW
<facet_core::types::def::smartptr::_::InternalBitFlags as core::fmt::Display>::fmt
found in core
148 🗑️ REMOVED
<facet_core::types::def::pointer::_::InternalBitFlags as core::str::traits::FromStr>::from_str
found in core
85 🆕 NEW
<facet_core::types::def::smartptr::_::InternalBitFlags as core::str::traits::FromStr>::from_str
found in core
85 🗑️ REMOVED
<facet_core::types::def::pointer::_::InternalBitFlags as core::fmt::Debug>::fmt
found in core
42 🆕 NEW
<facet_core::types::def::smartptr::_::InternalBitFlags as core::fmt::Debug>::fmt
found in core
42 🗑️ REMOVED
facet_core::types::def::pointer::SliceBuilderVTableBuilder::build
found in facet_core
31 🆕 NEW
facet_core::types::def::smartptr::SliceBuilderVTableBuilder::build
found in facet_core
31 🗑️ REMOVED
facet_core::types::def::pointer::PointerDefBuilder::build
found in facet_core
29 🆕 NEW
facet_core::types::def::smartptr::SmartPointerDefBuilder::build
found in facet_core
29 🗑️ REMOVED
facet_core::types::def::pointer::PointerDef::pointee
found in facet_core
8 🆕 NEW
facet_core::types::def::pointer::PointerDef::strong
found in facet_core
8 🆕 NEW
facet_core::types::def::pointer::PointerDef::weak
found in facet_core
8 🆕 NEW
facet_core::types::def::smartptr::SmartPointerDef::pointee
found in facet_core
8 🗑️ REMOVED
facet_core::types::def::smartptr::SmartPointerDef::strong
found in facet_core
8 🗑️ REMOVED
facet_core::types::def::smartptr::SmartPointerDef::weak
found in facet_core
8 🗑️ REMOVED
<facet_core::types::def::pointer::LockResult as core::ops::drop::Drop>::drop
found in core
7 🆕 NEW
<facet_core::types::def::smartptr::LockResult as core::ops::drop::Drop>::drop
found in core
7 🗑️ REMOVED
facet_core::types::def::pointer::_::<impl core::fmt::Binary for facet_core::types::def::pointer::PointerFlags>::fmt
found in facet_core
7 🆕 NEW
facet_core::types::def::pointer::_::<impl core::fmt::LowerHex for facet_core::types::def::pointer::PointerFlags>::fmt
found in facet_core
7 🆕 NEW

6 additional functions account for 2814 (📉 -14)

Wall duration: 6.09 s (📉 -0.24 s)

@fasterthanlime fasterthanlime enabled auto-merge July 3, 2025 14:05
@fasterthanlime fasterthanlime added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit 7dc3d96 Jul 3, 2025
18 checks passed
@fasterthanlime fasterthanlime deleted the not-so-smart-ptrs branch July 3, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant