Skip to content

Fix serialization for Option<T> in XDR #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RoastVeg
Copy link
Contributor

@RoastVeg RoastVeg commented Jul 7, 2025

Fixes #841

Copy link

github-actions bot commented Jul 7, 2025

📦 limpid report

Number of crates: 51 (➖ no change)
8350 symbols (➖ no change), totaling 885.5 KB (➖ no change)

Symbol Baseline Size Current Size Change
facet_core::types::def::list::ListDef::t
found in facet_core
3 B 🗑️ REMOVED
facet_core::types::def::set::SetDef::t
found in facet_core
3 B 🆕 NEW

All significant changes are listed above.

Number of LLVM lines: 351,318 (➖ no change)
Wall duration: 6.08 s (📉 -0.08 s)

@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Add start_some to serializer trait
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelogs are automatically generated from commit messages, so all manual changes will be overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

facet-xdr Optional Serialization missing leading bytes
2 participants