Allow facet-json to build with no-default-features #845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facet-json
doesn't currently build whendefault-features = false
because that disables thestd
features of all the underlying crates, andno-std
/no-alloc
doesn't necessarily compile in all of the facet crates atm.It's also just not reasonable to expect a general-purpose json serializer/deserializer to work out-of-the-box without std at the moment, so I think this is the correct solution to this problem.