Skip to content

Allow facet-json to build with no-default-features #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itsjunetime
Copy link

@itsjunetime itsjunetime commented Jul 7, 2025

facet-json doesn't currently build when default-features = false because that disables the std features of all the underlying crates, and no-std/no-alloc doesn't necessarily compile in all of the facet crates atm.

It's also just not reasonable to expect a general-purpose json serializer/deserializer to work out-of-the-box without std at the moment, so I think this is the correct solution to this problem.

@itsjunetime itsjunetime force-pushed the facet-json-no-rich-diagnostics branch from 4f8bbb4 to c267278 Compare July 7, 2025 05:53
Copy link

github-actions bot commented Jul 7, 2025

📦 limpid report

Number of crates: 51 (➖ no change)
8350 symbols (➖ no change), totaling 885.5 KB (➖ no change)

Symbol Baseline Size Current Size Change
facet_core::types::def::list::ListDef::t
found in facet_core
3 B 🗑️ REMOVED
facet_core::types::def::set::SetDef::t
found in facet_core
3 B 🆕 NEW

All significant changes are listed above.

Number of LLVM lines: 351,318 (➖ no change)
Wall duration: 6.12 s (📉 -0.21 s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant