Skip to content

Remove 'shape lifetime #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

Remove 'shape lifetime #855

merged 1 commit into from
Jul 23, 2025

Conversation

fasterthanlime
Copy link
Contributor

No description provided.

@fasterthanlime fasterthanlime force-pushed the static-shape branch 4 times, most recently from ce22b35 to 2763320 Compare July 23, 2025 19:03
Copy link

github-actions bot commented Jul 23, 2025

📦 limpid report

Number of crates: 50 (📉 -1)

Crate Baseline Size Current Size Change
ariadne 28.1 KB 26.1 KB 📉 -2.0 KB
facet_deserialize 57.4 KB 56.2 KB 📉 -1.2 KB
(Id,&ariadne 259 B 🗑️ REMOVED
ks_facet_json_read 7.6 KB 7.4 KB 📉 -236 B
std 510.6 KB 510.5 KB 📉 -99 B

All significant changes are listed above.

8350 symbols (➖ no change), totaling 881.7 KB (📉 -3.8 KB)

Symbol Baseline Size Current Size Change
ariadne::write::<impl ariadne::Report<S>>::write_for_stream
found in ariadne
21.3 KB 20.1 KB 📉 -1.3 KB
ariadne::write::<impl ariadne::Report<S>>::write_for_stream::{{closure}}
found in ariadne
4.1 KB 3.5 KB 📉 -608 B
facet_deserialize::StackRunner::pop
found in facet_deserialize
13.2 KB 12.7 KB 📉 -442 B
core::ptr::drop_in_place<ariadne::ReportBuilder<(&str,core::ops::range::Range<usize>)>>
found in std
427 B 🗑️ REMOVED
core::ptr::drop_in_place<ariadne::Report>
found in std
423 B 🆕 NEW
facet_deserialize::StackRunner::set_numeric_value
found in facet_deserialize
2.6 KB 2.3 KB 📉 -262 B
<(Id,&ariadne::source::Source<I>) as ariadne::source::Cache<Id>>::fetch
found in (Id,&ariadne
259 B 🗑️ REMOVED
ks_facet_json_read::catalog_from_json
found in ks_facet_json_read
7.6 KB 7.4 KB 📉 -236 B
facet_deserialize::StackRunner::value
found in facet_deserialize
10.3 KB 10.1 KB 📉 -190 B
core::ptr::drop_in_place<core::iter::adapters::enumerate::Enumerate<alloc::vec::into_iter::IntoIter<ariadne::write::SourceGroup<(&str,core::ops::range::Range<usize>)>>>>
found in std
153 B 🗑️ REMOVED
core::ptr::drop_in_place<core::iter::adapters::enumerate::Enumerate<alloc::vec::into_iter::IntoIter<ariadne::write::SourceGroup<core::ops::range::Range<usize>>>>>
found in std
153 B 🆕 NEW
<facet_deserialize::error::DeserError as core::fmt::Display>::fmt
found in facet_deserialize
4.4 KB 4.2 KB 📉 -142 B
core::ptr::drop_in_place<alloc::vec::Vec<ariadne::write::SourceGroup<(&str,core::ops::range::Range<usize>)>>>
found in std
134 B 🗑️ REMOVED
core::ptr::drop_in_place<alloc::vec::Vec<ariadne::write::SourceGroup<core::ops::range::Range<usize>>>>
found in std
134 B 🆕 NEW
facet_deserialize::StackRunner::object_key_or_object_close
found in facet_deserialize
6.7 KB 6.5 KB 📉 -120 B
<ariadne::display::Show<core::option::Option<T>> as core::fmt::Display>::fmt
found in ariadne
436 B 327 B 📉 -109 B
facet_deserialize::StackRunner::list_item_or_list_close
found in facet_deserialize
3.8 KB 3.7 KB 📉 -75 B
core::ptr::drop_in_place<alloc::boxed::Box<alloc::string::String>>
found in std
50 B 🗑️ REMOVED
facet_deserialize::StackRunner::pop::{{closure}}
found in facet_deserialize
724 B 692 B 📉 -32 B
<&T as core::fmt::Display>::fmt
found in std
875 B 850 B 📉 -25 B

3 additional symbols account for 23 B3 B (📉 -20 B)

Number of LLVM lines: 349,687 (📉 -1,631)

Function Baseline Lines Current Lines Change
ariadne::write::<impl ariadne::Report<S>>::write_for_stream
found in ariadne
4,709 4,409 📉 -300
facet_deserialize::StackRunner::pop
found in facet_deserialize
3,581 3,289 📉 -292
facet_deserialize::StackRunner::set_numeric_value
found in facet_deserialize
1,197 933 📉 -264
facet_deserialize::StackRunner::value
found in facet_deserialize
2,902 2,704 📉 -198
ariadne::write::<impl ariadne::Report<S>>::write_for_stream::{{closure}}
found in ariadne
921 763 📉 -158
facet_deserialize::StackRunner::object_key_or_object_close
found in facet_deserialize
1,851 1,723 📉 -128
core::ptr::drop_in_place<ariadne::Report>
found in core
99 🆕 NEW
core::ptr::drop_in_place<ariadne::ReportBuilder<(&str,core::ops::range::Range<usize>)>>
found in core
99 🗑️ REMOVED
facet_deserialize::StackRunner::list_item_or_list_close
found in facet_deserialize
1,071 1,009 📉 -62
<(Id,&ariadne::source::Source<I>) as ariadne::source::Cache<Id>>::fetch
found in ariadne
59 🗑️ REMOVED
ks_facet_json_read::catalog_from_json
found in ks_facet_json_read
1,238 1,189 📉 -49
core::ptr::drop_in_place<core::iter::adapters::enumerate::Enumerate<alloc::vec::into_iter::IntoIter<ariadne::write::SourceGroup<(&str,core::ops::range::Range<usize>)>>>>
found in core
35 🗑️ REMOVED
core::ptr::drop_in_place<core::iter::adapters::enumerate::Enumerate<alloc::vec::into_iter::IntoIter<ariadne::write::SourceGroup<core::ops::range::Range<usize>>>>>
found in core
35 🆕 NEW
<ariadne::display::Show<core::option::Option<T>> as core::fmt::Display>::fmt
found in core
128 96 📉 -32
core::ptr::drop_in_place<alloc::vec::Vec<ariadne::write::SourceGroup<(&str,core::ops::range::Range<usize>)>>>
found in core
27 🗑️ REMOVED
core::ptr::drop_in_place<alloc::vec::Vec<ariadne::write::SourceGroup<core::ops::range::Range<usize>>>>
found in core
27 🆕 NEW
<facet_deserialize::error::DeserError as core::fmt::Display>::fmt
found in core
824 807 📉 -17
facet_deserialize::StackRunner::pop::{{closure}}
found in facet_deserialize
176 160 📉 -16
facet_macros_emit::process_struct::process_struct
found in facet_macros_emit
3,309 3,293 📉 -16
core::ptr::drop_in_place<alloc::boxed::Box<alloc::string::String>>
found in core
12 🗑️ REMOVED

4 additional functions account for 6,1306,102 (📉 -28)

Wall duration: 6.06 s (📉 -0.17 s)

Closes #854

This also removes the 'source' property from facet-deserialize errors,
since this made the error large enough for clippy to take notice.
@fasterthanlime fasterthanlime marked this pull request as ready for review July 23, 2025 22:12
@fasterthanlime fasterthanlime changed the title wip: Remove 'shape lifetime Remove 'shape lifetime Jul 23, 2025
@fasterthanlime fasterthanlime merged commit 896590f into main Jul 23, 2025
17 of 18 checks passed
@fasterthanlime fasterthanlime deleted the static-shape branch July 23, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant