add qt5 deps to vcpkg for easier windows building #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickisos
approved these changes
May 3, 2023
Contributor
erickisos
left a comment
erickisos
left a comment
There was a problem hiding this comment.
Definitely makes sense.
|
This, plus adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to build in windows with vcpkg using the default vcpkg manifest. This seemed to work for me using the following steps:
(in repo folder)
mkdir build
cd build
cmake -G "Visual Studio 16 2019" .. -DCMAKE_TOOLCHAIN_FILE=\path\to\scripts\buildsystems\vcpkg.cmake
cmake --build .
Might be able to simplify the windows github actions as well using this method? (seems to depend on qt5 already being installed)
Cheers,
Nate