Skip to content

Addlogs#9 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Addlogs#9 #14

wants to merge 6 commits into from

Conversation

clemf
Copy link
Contributor

@clemf clemf commented May 18, 2015

Added eph logs command to CLI.

@coveralls
Copy link

Coverage Status

Coverage decreased (-46.73%) to 44.44% when pulling ee25a67 on clemf:addlogs#9 into 5bf7541 on factor-io:master.

skierkowski
skierkowski reviewed May 20, 2015
View reviewed changes
spec/client_spec.rb
@@ -2,6 +2,7 @@

require 'spec_helper'
require 'ephemeral/client'
require 'pry'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, this is why.

@skierkowski
Copy link
Member

Once the tests pass I'll merge this, but you need to remove the require 'pry' line which I believe is causing the failure.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.82%) to 98.0% when pulling efb9c60 on clemf:addlogs#9 into 5bf7541 on factor-io:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+6.82%) to 98.0% when pulling efb9c60 on clemf:addlogs#9 into 5bf7541 on factor-io:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clemf @coveralls @skierkowski