Merged
Conversation
thdaraujo
changed the title
This was referenced Jan 6, 2026
Closed
stefannibrasil
force-pushed
the
ta/reformat-locales
branch
3 times, most recently
from
ec50eea to
7d5e9c2
Compare
Contributor
|
The tests seem to be flaky. I will investigate tomorrow. |
stefannibrasil
changed the title
stefannibrasil
force-pushed
the
ta/reformat-locales
branch
from
52d478d to
c6039b4
Compare
Contributor
|
@thdaraujo I pushed some commits to this branch. Do you mind taking a look when you can? Thanks! 🙇🏼♀️ |
stefannibrasil
force-pushed
the
ta/reformat-locales
branch
from
ed11973 to
ee0b6ab
Compare
thdaraujo
commented
Jan 14, 2026
Contributor
Author
thdaraujo
left a comment
thdaraujo
left a comment
There was a problem hiding this comment.
makes sense to me!
This task reformats all YAML locales.
These files have been formatted using the new rake task. Note that I skipped the files that had changes such as single quotes vs quotes, and whitespace removal to keep this PR as small as it can possibly be. I did encounter a flaky test with the fr locale compass test. It got fixed when I edited the values to keep the quotes around them. Running the task again will remove whitespaces, comments, ident with two spaces, and other small things. Ideally, we won't need to run it again for all files, though. To keep moving forward with the next steps, I didn't fix the task to encounter for these small scenarios.
stefannibrasil
force-pushed
the
ta/reformat-locales
branch
from
bc15476 to
c3298b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Closes #3158
Additional information
Running the
reformat_localestask again will generate lots of changes because I skipped most of the changes below:''for a few items but not all of them, especially phone number/cell phone formatscompass.cardinal.abbreviationadded double quotes to "N" only'\d{3,19}#'to"\\d{3,19}#", for example.To keep this PR as small as it can possibly be, I skipped these scenarios (exception: I included a few of these changes in this separate commit bc15476). I reviewed the files twice and tested generators with locales. A few locales have tests, which was helpful.