Refactor: Improve UK Phone number false failure hit-rate#3136
Merged
thdaraujo merged 5 commits intofaker-ruby:mainfrom Nov 16, 2025
Merged
Refactor: Improve UK Phone number false failure hit-rate#3136thdaraujo merged 5 commits intofaker-ruby:mainfrom
thdaraujo merged 5 commits intofaker-ruby:mainfrom
Conversation
…t for better triage Updated en-GB.yml using references to the UK Drama regulations via ofcom -> https://www.ofcom.org.uk/phones-and-broadband/phone-numbers/numbers-for-drama Thanks to https://github.com/giggsey
thdaraujo
reviewed
Nov 16, 2025
Contributor
thdaraujo
left a comment
thdaraujo
left a comment
There was a problem hiding this comment.
Very nice, thank you! The commit message has enough context, so no need for these comments.
thdaraujo
approved these changes
Nov 16, 2025
stefannibrasil
pushed a commit
that referenced
this pull request
Jan 8, 2026
* UK Phone number update: Use better Ofcom regulations and self-document for better triage Updated en-GB.yml using references to the UK Drama regulations via ofcom -> https://www.ofcom.org.uk/phones-and-broadband/phone-numbers/numbers-for-drama Thanks to https://github.com/giggsey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the false failure hit-rate for UK Phone numbers. Partially alleviates #3135
Additional information
Reference from Ofcom drama list: https://www.ofcom.org.uk/phones-and-broadband/phone-numbers/numbers-for-drama
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: