Skip to content

Expose AWS_S3_ENDPOINT configuration #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gysel
Copy link

@gysel gysel commented Jun 26, 2024

What type of PR is this?

/kind documentation
/kind feature

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it:

Expose configuration option added with falcosecurity/falcosidekick#791.

@poiana poiana added kind/documentation Improvements or additions to documentation dco-signoff: yes kind/feature New feature or request labels Jun 26, 2024
@poiana
Copy link
Contributor

poiana commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gysel
Once this PR has been reviewed and has the lgtm label, please assign issif for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jun 26, 2024

Welcome @gysel! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana added the size/XS label Jun 26, 2024
@alacuku
Copy link
Member

alacuku commented Jun 26, 2024

Hi @gysel, thanks for the PR. Please, have a look to the contributing section in the docs: https://github.com/falcosecurity/charts#contributing

@Issif
Copy link
Member

Issif commented Jun 26, 2024

Hi,

The release 2.29.0 of Falcosidekick is scheduled for next week, I already prepared the upgrade of the Helm chart and it contains the change you propose: #696

Regards,

@gysel
Copy link
Author

gysel commented Jun 26, 2024

@Issif - excellent, thanks!

@gysel gysel closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/falcosidekick-chart dco-signoff: yes kind/documentation Improvements or additions to documentation kind/feature New feature or request size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants