FAI-17274: Filter undefined fields from upserts #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. don't map undefined to null when creating upserts
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that undefined field values are omitted (rather than mapped to null) when generating GraphQL upsert objects.
- Updated
formatFieldValueand upsert construction logic to skipundefinedvalues. - Added a new test and updated snapshots to verify undefined vs.
nullhandling.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/graphql-client.test.ts | Added a test case for filtering undefined fields. |
| test/snapshots/graphql-client.test.ts.snap | Updated snapshots to reflect omitted undefined fields. |
| src/graphql/client/graphql-client.ts | Changed object assembly to only include fields when value !== undefined. |
Comments suppressed due to low confidence (2)
src/graphql/client/graphql-client.ts:900
- Consider adding a brief comment above this condition explaining that undefined values are skipped to prevent them being mapped to null. This will clarify the intent for future maintainers.
if (val !== undefined) {
test/graphql-client.test.ts:869
- [nitpick] The test name 'undefined field' could be more descriptive. Consider renaming it to 'filter undefined fields from upsert' to clearly convey its purpose.
test('undefined field', async () => {
|
cjwooo
approved these changes
Jul 2, 2025
tovbinm
added
faros-ai-complexity-score-3
and removed
faros-ai-complexity-score-3
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't map undefined to null when creating upserts
Type of change