feat: support attaching trace id to log #88
Conversation
|
|
||
| use crate::Marker; | ||
|
|
||
| // TODO(tisonkun): use trait alias when it's stable - https://github.com/rust-lang/rust/issues/41517 |
There was a problem hiding this comment.
Just to align with the same comment in CustomLayout
There was a problem hiding this comment.
Good to go. But I may need one more round to consider whether Marker a good abstraction. It looks added random kvs with very niche use case .. I can't map it to other common log concepts.
very niche use case
That said, we add bridges for it everywhere but use it under a very specific way.
src/marker/mod.rs
Outdated
| #[cfg(feature = "fastrace")] | ||
| mod fastrace; | ||
|
|
||
| /// Represents a layout for formatting log records. |
There was a problem hiding this comment.
I suppose it's not a layout
|
It's mainly to extract context where the log is emitted. User can attach tokio's task_id, thread_id or cpu_id. |
| @@ -55,6 +56,7 @@ pub struct OpentelemetryLogBuilder { | |||
| protocol: Protocol, | |||
| labels: Vec<(Cow<'static, str>, Cow<'static, str>)>, | |||
| layout: Option<Layout>, | |||
| marker: Option<Marker>, | |||
There was a problem hiding this comment.
I'm confused why Marker is an Option. It looks like arbitrary kvs to be attached, then it can be 0 to n?
There was a problem hiding this comment.
Because user may not provide a marker implementation. If not using Option, we have to provide a NoopMarker.
There was a problem hiding this comment.
I mean, it may not be 0 or 1, but 0 to n.
There was a problem hiding this comment.
Yes. It can provide 0 to n extra kvs.
There was a problem hiding this comment.
Oops. I get it now .. The marker is the context (driver) and the f passed in is the method to populate kvs..
|
This looks like some concepts like MDC - https://logback.qos.ch/manual/mdc.html |
|
I think it's similar concept. But MDC is hardly a better name IMO... |
Agreed. I get it now the |
| let root = Span::root("root", SpanContext::random()); | ||
| let _g = root.set_local_parent(); | ||
|
|
||
| log::error!("Hello syslog error!"); |
There was a problem hiding this comment.
ooops. need to correct in the next pr.
No description provided.