refactor: marker is mdc #90
Conversation
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
| } | ||
|
|
||
| impl Diagnostic { | ||
| pub fn name(&self) -> &'static str { |
There was a problem hiding this comment.
What is this method for? Since it's supposed to by dyn.
There was a problem hiding this comment.
Previously I use it to filter all the context provided from FastraceDiagnostic in some case.
That is, a key-value in MDC can be considered as (context_name, key_name, value) and implementor of append/layout can filter kvs by either name. But it may not be used now and perhaps over design.
There was a problem hiding this comment.
It might be over designed.. The application, who configurates logforth, has the control over which diagnostic goes through which append. So I don't think it's necessary to let the append filter on diagnostic.
There was a problem hiding this comment.
Removed in a new PR.
| "thread-local" | ||
| } | ||
|
|
||
| pub fn insert<K, V>(&self, key: K, value: V) |
There was a problem hiding this comment.
As far as rustc can eliminate the overhead, I'd prefer to keep the helper struct to align concepts - https://x.com/tison1096/status/1877365316621115855
There was a problem hiding this comment.
How could the user, who want's to set the kv, get the MDC to call the methods?
There was a problem hiding this comment.
They are the same so it's easy to get a copy by let diag = ThreadLocalDiagnostic::default().
There was a problem hiding this comment.
But perhaps ThreadLocalDiagnostic::insert(k, v) would be OK.
| }); | ||
| } | ||
|
|
||
| pub fn remove(&self, key: &str) { |
Ref - rust-lang/log#655