Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix up a few tests requiring features #91

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix: Fix up a few tests requiring features #91

merged 2 commits into from
Jan 10, 2025

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Jan 9, 2025

Hi! 👋

I just cloned the source to have a look at rust-lang/log#655 and found a few tests that wouldn't build with a plain cargo check --all-targets, so fixed them up.

@KodrAus KodrAus changed the title Fix up a few tests requiring features fix: Fix up a few tests requiring features Jan 9, 2025
tisonkun
tisonkun approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I think we need to add cargo check --all-targets to CI workflow now or later :D

@tisonkun tisonkun merged commit 941449e into fast:main Jan 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KodrAus @tisonkun