Skip to content

✨ Add support for PEP695 type alias syntax #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

✨ Add support for PEP695 type alias syntax #1628

wants to merge 20 commits into from

Conversation

@stickm4n
Copy link

As a language feature for Python 3.12+ was introduced new type-alias definitions.
Reference here

They are not working in sqlmodel hence this PR to support them.

@stickm4n
Copy link
Author

@YuriiMotov could you review this and label it?

stickm4n
stickm4n commented Oct 29, 2025
View reviewed changes
@YuriiMotov YuriiMotov changed the title Type alias for Python 3.12+ is not working ✨ Add support for PEP695 type alias syntax Oct 29, 2025
@YuriiMotov YuriiMotov added the feature New feature or request label Oct 29, 2025
@stickm4n stickm4n mentioned this pull request Oct 29, 2025
Open
@YuriiMotov YuriiMotov marked this pull request as draft October 29, 2025 11:40
@YuriiMotov

This comment was marked as resolved.

Sign in to view
stickm4n
stickm4n commented Oct 29, 2025
View reviewed changes
@stickm4n stickm4n marked this pull request as ready for review October 29, 2025 12:16
@YuriiMotov
Copy link
Member

Could you please comment on the implementation of the algorithm?
Also, looks like the title and description of PR don't match the changes.
We should either split changes into several PRs (probably preferrable) or update title\description

@stickm4n
Copy link
Author

Could you please comment on the implementation of the algorithm?

Also, looks like the title and description of PR don't match the changes.

We should either split changes into several PRs (probably preferrable) or update title\description

Ok, it's a good idea.
I will document the changes referencing all PEPs that are supported with this.
When I was implementing it I noticed there were more type definitions that were not covered.
I thinks it's all type definitions, which are different from alias by variable assignment.

@stickm4n
Copy link
Author

@svlandeg could you please take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuriiMotov YuriiMotov YuriiMotov left review comments

Assignees

No one assigned

Labels

feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stickm4n @YuriiMotov