Open
Conversation
Contributor
📝 Docs previewLast commit 5a7bf84 at: https://3cf779e6.typertiangolo.pages.dev |
svlandeg
commented
Jan 6, 2026
svlandeg
commented
Jan 6, 2026
svlandeg
commented
Jan 6, 2026
svlandeg
commented
Jan 7, 2026
| return inspect.cleandoc(typer_info.help or "") | ||
| # Priority 2: Explicit value was set in sub_app.callback() | ||
| try: | ||
| if typer_info.typer_instance and typer_info.typer_instance.registered_callback: |
Member
Author
There was a problem hiding this comment.
This edit and the lines below is not strictly necessary: they are "possibly-missing-attribute" warnings from ty that won't fail the CI. Still, IMO it's nice to test for this explicitely up-front instead of having the try-catch. This is a bit of personal preference though, so will leave it to Tiangolo to make the final decision.
Member
Author
There was a problem hiding this comment.
Instead of making these edits, we have two other options:
- add
ty: ignorestatements - just leave the warnings as is (though this is somewhat annoying when running the tool locally and getting all the warnings output)
Member
Author
|
Ok this is ready for review @tiangolo. TLDR decisions to take:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, running
tyin parallel tomypyto see what kind of errors/warnings come up.