Handle Abort/Exit during shell completion#1487
Open
mpouzoup wants to merge 8 commits intofastapi:masterfrom
Open
Handle Abort/Exit during shell completion#1487mpouzoup wants to merge 8 commits intofastapi:masterfrom
mpouzoup wants to merge 8 commits intofastapi:masterfrom
Conversation
svlandeg
reviewed
Jan 12, 2026
Member
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Thanks for the PR! Can you look into the coverage tests that are failing?
svlandeg
reviewed
Jan 28, 2026
| assert out.err == "" | ||
|
|
||
|
|
||
| def test_fake_completion_default_methods_are_covered(): |
Member
There was a problem hiding this comment.
This is just to avoid coverage issues on this particular file, right? As it's a test file, it's cleaner to just add # pragma: no cover to those respective lines, no need to have a test testing the test 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #286
When running shell completion, autocompletion callbacks may raise click.exceptions.Abort or
click.exceptions.Exit. This should not print a traceback; completion should abort silently and
return no completions instead.