Conversation
23988ad to
08d1fac
Compare
debccf1 to
2a48587
Compare
Hi! Note that Python 3.6 support was recently dropped in 0.11.0. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Looks great, I'd love to see this get merged! Could we somehow also support custom types defined by users like pydantic? |
Me too 😁
TBH I think this PR covers most of cases we need for now and I prefer to keep it minimalistic to get a chance for it to be merged soon. |
0ac6ec0 to
707839e
Compare
|
@tiangolo Is this PR being considered? |
svlandeg
left a comment
There was a problem hiding this comment.
Hi @lachaib, thanks for this nice work! Really appreciate the detailed tests and documentation as well.
I'm going to spend some time going through this PR in detail - I might leave some more review comments in the process, and might also push a few changes directly to your branch 🙏
|
It looks like this PR is now failing, as we recently added Python 3.12 to the CI. I'll put this in draft while we work on it 🚧 |
tests/test_tutorial/test_parameter_types/test_pydantic_types/test_tutorial001.py
Outdated
Show resolved
Hide resolved
|
@svlandeg thanks for your additions, I'm wondering now what's next for this PR and how may we move forward to merging? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Recap of status of PR:
Recent conflicts fixed and PR brought up-to-date with latest changes on master (uv, test suite, etc).
I'm waiting for validation of the idea by Tiangolo, cf my earlier comments here. If he's happy to go ahead with this PR, one thing we should definitely do is make the pydantic-types.md doc page more extensive, describe the individual examples in more detail, etc.
This PR is "functional" as in "it does what was expected"
However, don't hesitate to request more tests, docs, or improvements on the code if needed to fit with the current standards
Fixes #181