Support for optional as UnionType (Python >= 3.10) #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkomet
force-pushed
the
mkomet/add-optional-uniontype
branch
4 times, most recently
from
7bba6a7
to
92d1179
Compare
Signed-off-by: Meir Komet <[email protected]>
mkomet
force-pushed
the
mkomet/add-optional-uniontype
branch
from
92d1179
to
311dfaa
Compare
mkomet
changed the title
mkomet
changed the title
svlandeg
added
feature
|
Also closes Another PR that also address this issue |
| @@ -816,8 +822,9 @@ def get_click_param( | |||
| is_tuple = False | |||
| parameter_type: Any = None | |||
| is_flag = None | |||
| is_union_type = lenient_issubclass(type(main_type), UnionType) | |||
There was a problem hiding this comment.
Hi, I'm new to this kind of stuff, could you please clarify this for me please? From the variable name, it is a type already, why do we need to convert it to type() here? Is it just your preference or there are some edge cases being handled implicitly here?
svlandeg
reviewed
May 21, 2024
There was a problem hiding this comment.
Hi, thanks for this PR!
There's a few other PRs that address the same issue, of which I think #548 would be the prime candidate to merge. That PR uses existing functionality such as utils.needs_py310 and ._typing.is_union. If we merge #548, I think we can go ahead and close this one.
I'll leave the final decision with Tiangolo though.
7 tasks
This was
linked to
issues
May 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue #533