Skip to content

Conversation

@jesse-r-s-hines
Copy link

@jesse-r-s-hines jesse-r-s-hines commented Jun 20, 2025

Implement remote_tags and implement_digest_tag arguments to k8s_deploy

Description

There are already stubs for an image_digest_tag option, which is documented to tag all pushes with the short digest. Here I implement the option. I've also added a remote_tags option so we can set it to push to latest etc. as well.

Related Issue

Fixes #59

Motivation and Context

Many container registries will garbage collect images pushed without a tag, tagging pushes with a hash is an easy way to avoid that issue.

How Has This Been Tested?

We are currently using this patch in our OpenShift deployment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@michaelschiff
Copy link
Collaborator

Hi thanks for the PR! Give us a couple days to take a look and we will get back to you with any questions/concerns or a ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement image_digest_tag

2 participants