RUNFILES_DIR env var undefined for .push run during a .apply
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add RUNFILES_DIR=${RUNFILES} to async function so that child bash
scripts (like .push scripts) can find runfiles.bash. Without this,
child scripts fail with "runfiles.bash initializer cannot find
bazel_tools/tools/bash/runfiles/runfiles.bash" error.
The issue occurs because:
- Parent scripts only export PYTHON_RUNFILES (Python-specific)
- Child bash scripts check RUNFILES_DIR environment variable
- Without RUNFILES_DIR, runfiles.bash initialization fails
Add RUNFILES_DIR=${RUNFILES} to async function in k8s_gitops.sh.tpl.
This template is used by k8s_deploy.apply (not k8s_test_namespace.sh.tpl
which is for tests only).
Add RUNFILES_DIR=${RUNFILES} to async function in kubectl.sh.tpl.
This is the actual template used by the kubectl rule which generates
the k8s_deploy.apply target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
I believe this is a bug — however I could be wrong.
Ran into issues with the RUNFILES_DIR var undefined while
.applyfrom a github action runner environment. This PR fixed the issue for me. Opening this PR for a discussion or for this fix to be validated and merged.How Has This Been Tested?
Via internal GH actions
Types of changes
Checklist: