Merged
Conversation
gurgunday
approved these changes
May 29, 2024
Member
gurgunday
left a comment
There was a problem hiding this comment.
I didn't provide feedback before as I had no strong opinions and have never used the library
If you think this is better, I am behind it
gurgunday
approved these changes
May 31, 2024
Member
gurgunday
left a comment
There was a problem hiding this comment.
Yeah this looks good, I was going to merge, but this is breaking right?
Should we merge to next?
Member
Author
|
Changing of test seems to indicate this is breaking, but actually not. The new behavior is introduced in 5.8.1 and it was never tested before. Here is just reverting to behavior to the user most expected one. |
mcollina
approved these changes
May 31, 2024
Member
mcollina
left a comment
There was a problem hiding this comment.
lgtm
Thanks @climba03003, I've been buried down in work.
2 tasks
climba03003
added a commit
that referenced
this pull request
Jun 17, 2024
This reverts commit d508f82.
4 tasks
jean-michelet
pushed a commit
that referenced
this pull request
Jun 17, 2024
This reverts commit d508f82.
jean-michelet
added a commit
that referenced
this pull request
Jun 17, 2024
This reverts commit 1833842.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since no core member add value to #376 (comment)
I want to move things forward to users desire behavior.
Fixes #376
As mention in last submitted PR, I believe the long term solution is refactor the code to create a single tree that contain both
hookandplugininformation.Checklist
npm run testandnpm run benchmarkand the Code of conduct