Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate to node test runner #327

Merged
merged 9 commits into from
Mar 1, 2025
Merged

test: migrate to node test runner #327

merged 9 commits into from
Mar 1, 2025

Conversation

ilteoood
Copy link
Contributor

Checklist

Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need deepStrictEqual on assertions rather than strictEqual?

@ilteoood ilteoood requested a review from dancastillo February 13, 2025 19:55
@Eomm
Copy link
Member

Eomm commented Mar 1, 2025

There is this failure on win:

not ok 40 - Should expose websocket and http route
  ---
  duration_ms: 19.3431
  location: 'D:\\a\\fastify-websocket\\fastify-websocket\\test\\router.test.js:98:1'
  failureType: 'testCodeFailure'
  error: 'plan expected 4 assertions but received 3'
  code: 'ERR_TEST_FAILURE'
  ...

could you check it?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5b01e0f into fastify:main Mar 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants