Skip to content

feat: set sidebar position for pages #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2025

Conversation

golopot
Copy link
Contributor

@golopot golopot commented May 9, 2025

Description

  1. Move up introduction in sidebar.
  2. Move up basic pages before advanced topics, in the order of
  • Getting-Started
  • Database
  • Recommendations
  • Testing
image image

Related Issues

Fixes #308

Check List

@golopot golopot force-pushed the intro-sidebar-position branch from 658218f to ddd81f7 Compare May 10, 2025 05:09
@golopot golopot changed the title feat: set sidebar position for "introduction" feat: set sidebar position for pages May 10, 2025
Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eomm
Copy link
Member

Eomm commented May 10, 2025

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I would move the How to write a good plugin after the testing page - but I think it is already good!

image

Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Eomm's suggestions. I also think Recommendations should come before Databases, and then i'm happy!

@golopot
Copy link
Contributor Author

golopot commented Jun 27, 2025

Hi this is the updated order of pages:

Getting-Started
Recommendations
Database
Testing
How to write a good plugin
...Rest

@Eomm Eomm merged commit 0c421e3 into fastify:main Jun 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper ordering of pages in sidebar
3 participants