Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @fastly/cli in the scaffolded application #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harmony7
Copy link
Collaborator

@harmony7 harmony7 commented Nov 4, 2024

This PR makes changes to use @fastly/cli now available as an npm package:

  • Changes to the package.json in the scaffolded application to enable usage without a global installation of the Fastly CLI:

    • Adds @fastly/cli to devDependencies so that it's available in the scaffolded application, as a tool used to build and run or publish the application.
    • Makes sure that scripts contains start and deploy scripts as applicable.
  • Updates instructions to the README as well as the command output describing how to initialize an application, as well as how to run it locally or publish it to a Fastly service, as applicable.

@harmony7 harmony7 requested review from a team and kpfleming and removed request for a team November 4, 2024 07:57
In this case, `fastly.toml` has no value for `service_id` at the time you deploy, so `fastly compute publish` will prompt
you to create a Fastly service in your account for you (afterwards saving the new service's ID to your `fastly.toml` file).
In this case, `fastly.toml` has no value for `service_id` at the time you deploy, so the Fastly CLI will prompt
you to create a Fastly service in your account for you, after which it will save the new service's ID to your `fastly.toml` file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
you to create a Fastly service in your account for you, after which it will save the new service's ID to your `fastly.toml` file.
you to create a Fastly service in your account, after which it will save the new service's ID to your `fastly.toml` file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants