feat(acls): Implement compute acls #987
Conversation
|
hey @philippschulte. you have time for a read? |
There was a problem hiding this comment.
Tests pass and this is the same state as #972 just could not reopen that one
I was waiting for you to complete this PR. This is not the same state as #972. The Compute ACL entries implementation is missing.
Before you add the missing resource please address all of my comments first. Please don't force push. Thank you!
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### ENHANCEMENTS: | |||
|
|
|||
| - feat(acl): add support for Compute@Edge ACLs | |||
There was a problem hiding this comment.
Please replace all instances of Compute@Edge with Compute in the entire pr. Please also add the link to the PR.
| resource "fastly_compute_acl" "example" { | ||
| name = "example_acl" | ||
| force_destroy = true | ||
| } |
There was a problem hiding this comment.
Please add a new line at the end: https://stackoverflow.com/questions/5813311/whats-the-significance-of-the-no-newline-at-end-of-file-log.
|
|
||
| [1]: https://developer.fastly.com/reference/api/acls/ | ||
|
|
||
| {{ .SchemaMarkdown | trimspace }} |
There was a problem hiding this comment.
Please add a new line at the end: https://stackoverflow.com/questions/5813311/whats-the-significance-of-the-no-newline-at-end-of-file-log.
| @@ -0,0 +1,775 @@ | |||
| { | |||
There was a problem hiding this comment.
Please remove this file.
| @@ -0,0 +1 @@ | |||
| terraform import fastly_acl.example 7d991f5f-7c40-4c8c-a0c1-6ea5e45e4bcf/entries | |||
There was a problem hiding this comment.
The filename and resource name doesn't look right.
| resource "fastly_compute_acl" "example" { | ||
| name = "example_acl" | ||
| force_destroy = true | ||
| } |
There was a problem hiding this comment.
To make it complete please add:
data "fastly_package_hash" "example" {
filename = "package.tar.gz"
}
| ``` | ||
| ``` | ||
|
|
||
| ## Argument Reference |
There was a problem hiding this comment.
Please remove this since the schema gets generated at the bottom.
| * `name` - (Required) A unique name to identify the ACL. | ||
| * `force_destroy` - (Optional) Allow the ACL to be deleted even if it contains entries. Defaults to `false`. | ||
|
|
||
| ## Attributes Reference |
There was a problem hiding this comment.
Please remove this since the schema gets generated at the bottom.
| $ terraform import fastly_compute_acl.example 7d991f5f-7c40-4c8c-a0c1-6ea5e45e4bcf | ||
| ``` | ||
|
|
||
| Where `7d991f5f-7c40-4c8c-a0c1-6ea5e45e4bcf` is the ACL ID. |
| resource "fastly_compute_acl" "example" { | ||
| name = "example_acl" | ||
| force_destroy = true | ||
| } |
There was a problem hiding this comment.
Please add the following to make the example complete:
data "fastly_package_hash" "example" {
filename = "package.tar.gz"
}
|
gah, opened the wrong PR. let me find the right branch |
|
@jmoney please use this PR because it has 40 comments for the data and compute ACL resource already! Just add the missing resource. Thank you! |
|
can do! |
accidentally removed the whole template, sorry.
Tests pass and this is the same state as #972 just could not reopen that one