Skip to content

Fix some bugs in BAMBI & improve PR reviewer experience #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 16, 2025

Conversation

khyatimahendru
Copy link
Collaborator

@khyatimahendru khyatimahendru commented Jul 15, 2025

  • Preserve order of keys in the file on disk while merge to reduce number of changes in diff.
  • Update timestamp when a device property changes.
  • Fix for the reported bugs:
    • Site metadata tags get imported with square brackets when using the BAMBI add-on. Brackets should be removed.
    • Empty discovery block should be retained, currently it gets removed if empty.
    • testing.targets.invalid.target_value changes from array to string. Handle to retain array.
    • Point ref gets changed from string to integer, this could potentially break the config. It should not be auto-casted to a number
    • Handle exception for read from invalid json file

@khyatimahendru khyatimahendru changed the title Fix handling of site_metadata tags as a list Fix some bugs in BAMBI Jul 15, 2025
@khyatimahendru khyatimahendru marked this pull request as ready for review July 16, 2025 06:59
@khyatimahendru khyatimahendru changed the title Fix some bugs in BAMBI Fix some bugs in BAMBI & improve PR reviewer experience Jul 16, 2025
@khyatimahendru khyatimahendru requested a review from grafnu July 16, 2025 07:00
@khyatimahendru khyatimahendru merged commit f400bfe into faucetsdn:master Jul 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants