Skip to content

Commit

Permalink
use only tags with prefix v for version determination
Browse files Browse the repository at this point in the history
  • Loading branch information
cgroschupp committed Jul 3, 2023
1 parent 04a5079 commit 2c6655c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ BINARY ?= external-dns
SOURCES = $(shell find . -name '*.go')
IMAGE_STAGING = gcr.io/k8s-staging-external-dns/$(BINARY)
IMAGE ?= us.gcr.io/k8s-artifacts-prod/external-dns/$(BINARY)
VERSION ?= $(shell git describe --tags --always --dirty)
VERSION ?= $(shell git describe --tags --always --dirty --match "v*")
BUILD_FLAGS ?= -v
LDFLAGS ?= -X sigs.k8s.io/external-dns/pkg/apis/externaldns.Version=$(VERSION) -w -s
ARCHS = amd64 arm64 arm/v7
Expand Down
2 changes: 1 addition & 1 deletion scripts/releaser.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function generate_changelog {
# current tag is a full release
previous_tag=""
while [[ -z $previous_tag || ( $previous_tag == *-* && $current_tag != *-* ) ]]; do
previous_tag="$(git describe --tags "$start_ref"^ --abbrev=0)"
previous_tag="$(git describe --tags "$start_ref"^ --abbrev=0 --match "v*")"
start_ref="$previous_tag"
done

Expand Down
2 changes: 1 addition & 1 deletion scripts/run-trivy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ chmod +x trivy

# run trivy
cd -
/tmp/trivy image --exit-code 1 us.gcr.io/k8s-artifacts-prod/external-dns/external-dns:$(git describe --tags --always --dirty)
/tmp/trivy image --exit-code 1 us.gcr.io/k8s-artifacts-prod/external-dns/external-dns:$(git describe --tags --always --dirty --match "v*")

0 comments on commit 2c6655c

Please sign in to comment.