Add SASL config properties sugar function to ConsumerSettings
#1226
Conversation
wonk1132
changed the title
| @@ -417,6 +425,15 @@ object ConsumerSettings { | |||
| override val recordMetadata: ConsumerRecord[K, V] => String, | |||
| override val maxPrefetchBatches: Int | |||
| ) extends ConsumerSettings[F, K, V] { | |||
|
|
|||
| def withPlainSasl(usernameToken: String, passwordToken: String): ConsumerSettings[F, K, V] = | |||
There was a problem hiding this comment.
I've never worked with SASL but from what I can see here in PlainLoginModule there's no reference to any token.
Why not removing that prefix? 👇🏽
| def withPlainSasl(usernameToken: String, passwordToken: String): ConsumerSettings[F, K, V] = | |
| def withPlainSasl(username: String, password: String): ConsumerSettings[F, K, V] = |
| * provides SASL credentials to Kafka host. A typical use case for this would be | ||
| * interacting with Confluent Cloud. |
There was a problem hiding this comment.
I feel the second sentence is not needed. A user should be aware of what SASL is at this point (either by reading the docs or because he/she knows what's doing).
| * provides SASL credentials to Kafka host. A typical use case for this would be | |
| * interacting with Confluent Cloud. | |
| * Provides SASL credentials to Kafka host. |
| @@ -122,6 +122,23 @@ ConsumerSettings( | |||
| .withGroupId("group") | |||
| ``` | |||
|
|
|||
| ### Sasl setting | |||
There was a problem hiding this comment.
| ### Sasl setting | |
| ### SASL settings |
| <idToken>, | ||
| <passwordToken> |
There was a problem hiding this comment.
Same here, I don't think mentioning token is needed.
Also, here you are using id instead of username. I'd suggest to use the same convention everywhere.
aartigao
changed the title
ConsumerSettings
| * provides SASL credentials to Kafka host. A typical use case for this would be | ||
| * interacting with Confluent Cloud. | ||
| */ | ||
| def withPlainSasl(usernameToken: String, passwordToken: String): ConsumerSettings[F, K, V] |
There was a problem hiding this comment.
Could this be a new KafkaCredentialStore rather than being directly on the consumer settings? That would also add support for the producer and admin client.
Adds a sugar function in
ConsumerSettingsfor SASL. A primary use case for this newwithPlainSaslmethod is when the client needs to authenticate to Kafka hosted in Confluent Cloud.