Update sbt-typelevel to 0.5.3 in series/3.x #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aartigao
changed the title
aartigao
force-pushed
the
sbt-typelevel-0.5.3
branch
from
8e0604e
to
51ffcf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping to latest 0.5.x version of
sbt-typelevel(this PR supersedes #1244 which didn't compile 2.13 due to a bug).As noted in v0.5.0 release notes:
I had to move the import
inside
asJavaMapto force the implicit resolution ofasJavainstead of trying to use the one inFoldableSyntax.EDIT (29/09/2023)
For Scala 3.3.x, some compiler options were added that caused some compilation failures for warnings:
discarded non-Unit value of type StringBuilderunused private memberInstead of trying to fix them here in this PR, I took the fast path to rollback to previous state and remove the offending compiler options. In the end, those warnings for Scala 3 have been there, hidden, in the previous versions without issues (that includes versions 2.12 and 2.13 too). I think it's best to address them in the future, in an eventual Scala 3 syntax migration, but there's a lot work to do before that.