Fix compilation after #1340 merge

[aartigao]

No description provided.

[aartigao]

@rodrigo-molina I forgot that your PR didn't ran CI and there were some compilation issues that I try to fix here.

@vlovgr I bumped the base version to 3.6 but MiMa is complaining about compatibility for the new added methods. Do you think these errors should be filtered? I'm not much versed in MiMa but why adding new methods is not compatible? 😢

[vlovgr]

@vlovgr I bumped the base version to 3.6 but MiMa is complaining about compatibility for the new added methods. Do you think these errors should be filtered? I'm not much versed in MiMa but why adding new methods is not compatible? 😢

Yes, we should be able to ignore these, since ProducerSettings is sealed and ProducerSettingsImpl is private.

This can be done by adding:

ProblemFilters.exclude[ReversedMissingMethodProblem]("fs2.kafka.ProducerSettings.failFastProduce"),
ProblemFilters.exclude[ReversedMissingMethodProblem]("fs2.kafka.ProducerSettings.withFailFastProduce"),
ProblemFilters.exclude[DirectMissingMethodProblem]("fs2.kafka.ProducerSettings#ProducerSettingsImpl.copy"),
ProblemFilters.exclude[DirectMissingMethodProblem]("fs2.kafka.ProducerSettings#ProducerSettingsImpl.this"),
ProblemFilters.exclude[DirectMissingMethodProblem]("fs2.kafka.ProducerSettings#ProducerSettingsImpl.apply")

to the existing mimaBinaryIssueFilters in build.sbt.

[rodrigo-molina]

@rodrigo-molina I forgot that your PR didn't ran CI and there were some compilation issues that I try to fix here.

@vlovgr I bumped the base version to 3.6 but MiMa is complaining about compatibility for the new added methods. Do you think these errors should be filtered? I'm not much versed in MiMa but why adding new methods is not compatible? 😢

so sorry to read/hear that!

Thanks for taking care of the fixups, I somehow missed the warnings. Is there a way I could run the CI in a Pull Request from a fork?

Let me know if there is something I can do!

[aartigao]

Let me know if there is something I can do!

Yep! Running the SBT command + ci will do the trick of checking everything 🙂

[aartigao]

But anyways, it was my fault. When you create a PR, the CI should be approved from one maintainer IIRC.

[rodrigo-molina]

Yep! Running the SBT command + ci will do the trick of checking everything 🙂

Noted it.

When you create a PR, the CI should be approved from one maintainer IIRC.

Indeed, or having branch protection with the CI GH action execution.

Thanks again for taking it.