fix: reset spillover after poll loop #1398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the face of backpressure, spillover records that couldn't be offered to the queue would be registered, and wouldn't always be cleared afterwards, leading to duplicate records being offered. This is addressed by ensuring spillover records are always reset at the end of the poll loop.
In an earlier iteration of #1369 spillover records were reset early in the poll loop. At the end of the loop only remaining spillover records needed to be recorded. In the approach that ended up being submitted spillover records are reset only once at the end of the poll loop, but logic from the earlier iteration was inadvertently left behind that skipped this reset operation in the case there were no remaining spillover records to register.