feat: Implemented RebalanceRevokeMode #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookievx
force-pushed
the
rebalance-revoke-mode-v2
branch
2 times, most recently
from
75b4766 to
07cb0f9
Compare
wookievx
force-pushed
the
rebalance-revoke-mode-v2
branch
from
07cb0f9 to
8687b76
Compare
This is potential solution for fd4s#1200. Allowing for opting-in for graceful revoke handling (waiting for all the streams to finish, which should imply all the commits as well)
wookievx
force-pushed
the
rebalance-revoke-mode-v2
branch
from
8687b76 to
64130f7
Compare
|
@vlovgr It would be great if you could take a look. I am open to suggestions, feel free to comment. Just so you know: we succesfuly fixed production issues with the version from this fork, (rebalance suspension seems to be working in real life scenario). |
|
This looks great @wookievx. Thanks! Will merge and release in 3.9.0. |
|
Hope you don't mind a quick question here. Why re-use the session timeout, instead of a separate value? (We have quite a high session timeout, as we're using cooperative partition assigners). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is potential solution for #1200. Allowing for opting-in for graceful revoke handling (waiting for all the streams to finish, which should imply all the commits as well)