Simple but not ideal fix for remove sides in ElementSubdomainModifier#3
Merged
fdkong merged 2 commits intofdkong:amr_for_am_1from Jan 12, 2022
Merged
Conversation
Author
|
@fdkong we can talk if this may need further changes in your libmesh PR libMesh/libmesh#3094 |
dewenyushu
force-pushed
the
fix_elem_remove_side
branch
from
01a7985 to
3296609
Compare
GiudGiud
pushed a commit
that referenced
this pull request
Oct 23, 2022
Combine branches to have correct history
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comments in the code.
When we have AMR with ElementSubdomainModifier,
remove_side()triggers libmesh error since for child elements,_children_on_boundary falseThis fix avoids the error but is not ideal.