-
Notifications
You must be signed in to change notification settings - Fork 38
ci: add Image Mode test automation without Packit #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ff2a7b4
to
839d050
Compare
@yih-redhat can you review this please? |
839d050
to
1afca9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed manually and with github copilot, no syntactical or semantic issues found. I have one very minor nit just for consistency.
1afca9e
to
82e3cbd
Compare
@mcattamoredhat Hi, I am not familiar with the tmt structure in this pr (it's different than what I did before), just wondering if the workflow can find the tmt plan/tests and trigger test script properly? |
@yih-redhat This is because The workflow is able to discover tmt plans/tests thanks to |
Pulled this down and built successfully on my local machine. Thanks for fixing that minor nit too. It looks like there's a couple of clippy/spelling issues but otherwise LGTM. (I see the dev container and triage failures too but I think those are unrelated, someone please correct me if I'm wrong though.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing tests have nothing to do with the proposed changes and overall it LGTM
82e3cbd
to
4e68288
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4e68288
to
1a3549e
Compare
This is an approach to add Image Mode RHEL-10 ci tests without using Packit, and making rpm packages within the testing farm spawned VM instead.
The reason to proceed without Packit is to circumvent the difficulty of handling environment secrets, that implies encrypting needed secrets in every fork that opens a pull request against upstream repository.