Skip to content

Type Numerical Action #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Type Numerical Action #213

merged 1 commit into from
Mar 31, 2025

Conversation

relma2
Copy link
Contributor

@relma2 relma2 commented Dec 27, 2024

Added a type-numerical action to rofimoji that uses the typer to type Ctrl+Shift+U+<unicode> to enter an emoji by its unicode codepoint directly.

I still need help implementing the typer functions. I don't have the compositor for wtype, so I just guessed how it works and din't test it properly

@relma2 relma2 marked this pull request as ready for review December 27, 2024 23:45
@relma2 relma2 mentioned this pull request Dec 27, 2024
@relma2
Copy link
Contributor Author

relma2 commented Jan 6, 2025

@fdw please look at my PR

Copy link
Owner

@fdw fdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait!

Looking good so far, just some smaller comments left.

@relma2 relma2 requested a review from fdw March 13, 2025 02:49
@relma2
Copy link
Contributor Author

relma2 commented Mar 13, 2025

@fdw sorry for the delay; life got in the way, bu now i am ready to move forward on this PR

Copy link
Owner

@fdw fdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait; you caught me at a busy time.

Looking good so far, thank you

Copy link
Owner

@fdw fdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and could you please rebase onto main instead of merging? The diff is quite confusing and the history doesn't look better, either.

Also, feel free to squash your commits.

Thank you very much! 🙂

@relma2 relma2 force-pushed the relma2/numericalinput branch 2 times, most recently from 68d589a to e752be4 Compare March 31, 2025 04:59
Along with other reviewer comments
@relma2 relma2 force-pushed the relma2/numericalinput branch from 20e44c2 to 9195ee4 Compare March 31, 2025 05:41
@relma2
Copy link
Contributor Author

relma2 commented Mar 31, 2025

Squashed commits; also the rofi picker is invisible on my laptop; I think this is a rofi bug

@fdw fdw merged commit 9ae3cd3 into fdw:main Mar 31, 2025
5 checks passed
@fdw
Copy link
Owner

fdw commented Mar 31, 2025

Awesome, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants