-
Notifications
You must be signed in to change notification settings - Fork 50
Type Numerical Action #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@fdw please look at my PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the wait!
Looking good so far, just some smaller comments left.
@fdw sorry for the delay; life got in the way, bu now i am ready to move forward on this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the wait; you caught me at a busy time.
Looking good so far, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and could you please rebase
onto main
instead of merging? The diff is quite confusing and the history doesn't look better, either.
Also, feel free to squash your commits.
Thank you very much! 🙂
68d589a
to
e752be4
Compare
Along with other reviewer comments
20e44c2
to
9195ee4
Compare
Squashed commits; also the rofi picker is invisible on my laptop; I think this is a rofi bug |
Awesome, thank you very much! |
Added a
type-numerical
action to rofimoji that uses the typer to typeCtrl+Shift+U+<unicode>
to enter an emoji by its unicode codepoint directly.I still need help implementing the typer functions. I don't have the compositor for wtype, so I just guessed how it works and din't test it properly